Skip to content

Conversation

nicksanford
Copy link

No description provided.

@nicksanford nicksanford marked this pull request as draft February 10, 2025 02:02
:undefined ->
raise "undefined address for ranch server"

:local ->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with the other PR, please add tests for the change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe when using :local, the handling of the address would be a bit different as it needs the socket file returned in port to decide which is the unix file descriptor handling the connection

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, seeing as this is only used in logs, we can perhaps add that info to Logger.metadata and return "local" as it is now.

@polvalente polvalente closed this Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants